Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot Delete Tiddlers on Linux 64 bit #66

Closed
mklauber opened this issue Aug 10, 2015 · 6 comments
Closed

Cannot Delete Tiddlers on Linux 64 bit #66

mklauber opened this issue Aug 10, 2015 · 6 comments
Milestone

Comments

@mklauber
Copy link
Contributor

Clicking the trash can during edit mode does not seem to delete the tiddler.

I think it's related to nwjs/nw.js#2683

Essentially, before version nw12, there is a bug in nw.js that prevents the alert and confirm dialog from displaying. Instead they always return immediately, with the confirm dialog at least returning false. As you might expect, this makes it difficult to delete tiddlers. Not sure how to fix this besides updating the version of nw.js that tiddlyDesktop is built on, and I'm sure that's not a simple easy thing to do.

Anyway, just wanted to give you a heads up and add the info I'd determined. If you need someone to test a fix at some point, let me know and I may be able to help.

@Jermolene
Copy link
Member

Hi @mklauber apologies for the very slow response. I'll do an update to TiddlyDesktop including an upgrade of nw.js as soon as I can.

@mklauber mklauber reopened this Sep 11, 2015
@mklauber
Copy link
Contributor Author

Just as a FYI, I managed to build this with nwjs-v0.12.3 (with minor changes to the build script) and can confirm that this bug is fixed with the new version.

@Jermolene
Copy link
Member

Hi @mklauber I'm preparing a v0.0.5 update that is based on nw.js v0.12.3. I'd appreciate any feedback if you're able to build and test the master branch. Thanks!

@Jermolene Jermolene modified the milestone: v0.0.5 Oct 22, 2015
@mklauber
Copy link
Contributor Author

Built Successfully, seems to be working (I could build everything, but only tested it on linux x64, as that's what my machine is.). Also, appears that #65 is fixed in this build as well.

@mklauber
Copy link
Contributor Author

As soon as it's released, feel free to close this bug.

@Jermolene
Copy link
Member

Thanks @mklauber, much appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants