Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alert and confirm js functions are not showing dialogs on 0.11.1 #2683

Closed
uggrock opened this issue Nov 24, 2014 · 12 comments
Closed

Alert and confirm js functions are not showing dialogs on 0.11.1 #2683

uggrock opened this issue Nov 24, 2014 · 12 comments
Assignees
@rogerwang

Comments

@uggrock
Copy link

uggrock commented Nov 24, 2014

alert() returns undefined and confirm() returns alway false in console
@kenherbert
Copy link

alert() shouldn't return anything, so that is the expected behaviour, and is what is seen in both Chrome and Firefox, and I would assume many others.

@uggrock
Copy link
Author

uggrock commented Nov 24, 2014

alert and confirm show on the chrome and firefox a dialog, in the node-webkit currently there is not dialog.

@uggrock uggrock changed the title Alert and confirm js functions are not working on 0.11.1 Alert and confirm js functions are not showing dialogs on 0.11.1 Nov 24, 2014
@kenherbert
Copy link

Works fine for me on Windows 7 64-bit using the 32-bit node-webkit 0.11.1 package.

It would be useful if you included your OS.

@uggrock
Copy link
Author

uggrock commented Nov 24, 2014

Ubuntu 14.10, 64bit

@luozhihua
Copy link

same issues for me, I used nw v0.11.2, os is Ubuntu 14.10 64bit

@EthraZa
Copy link

EthraZa commented Dec 1, 2014

I thought it was a "feature". :P

Atte.

Allan Brazute Alves
Analista de Sistemas
GHSix Serviços de Internet
+55 (11) 2967-6868
allan@ghsix.com.br / www.ghsix.com.br

2014-12-01 14:05 GMT-02:00 Colin Luo notifications@github.com:

same issues for me. Ubuntu 14.10 64bit

—
Reply to this email directly or view it on GitHub
#2683 (comment)
.

@hamidabdulmalik
Copy link

have we gotten a fix on this yet?

@uggrock
Copy link
Author

uggrock commented Dec 10, 2014

on linux in 0.11.2 it is still reproducible...

@uggrock
Copy link
Author

uggrock commented Dec 26, 2014

in version 0.11.4 this issue is still reproducible on 64bit linux , please fix ...

@rogerwang rogerwang self-assigned this Dec 26, 2014
@jbaron jbaron mentioned this issue Dec 29, 2014
Closed
@bryceosterhaus
Copy link

on version 0.11.5, issue is still reproducible on 64bit linux. I would also very much appreciate a fix to this! Thank you

@hugecannon
Copy link

Alert/Confirm/Prompt not working for me on Ubuntu 14.04.1 + NW v0.11.3

rogerwang added a commit that referenced this issue Jan 6, 2015
@rogerwang
Fix linux javascript dialog
e31985d 
Fix #2683
@rogerwang
Copy link
Member

This is fixed in the 'nw12' branch, will be released with v0.12.

Now you can try it from the live build: http://dl.node-webkit.org/live-build/01-07-2015/e46d09d-02026f1-b477a2d-2e978ac-8c5a736-fd87c8d/

rogerwang added a commit that referenced this issue Jan 9, 2015
@rogerwang
Fix linux javascript dialog
5860b0d 
Fix #2683

Conflicts:
	nw.gypi
	src/nw_shell.cc
	src/shell_browser_main_parts.cc
@mklauber mklauber mentioned this issue Aug 10, 2015
Closed
@juliandescottes juliandescottes mentioned this issue Mar 5, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rogerwang rogerwang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@rogerwang @hamidabdulmalik @hugecannon @EthraZa @uggrock @luozhihua @bryceosterhaus @kenherbert