Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support plugins/publisher in wiki folders #1309

Open
Jermolene opened this issue Jan 3, 2015 · 5 comments
Open

Support plugins/publisher in wiki folders #1309

Jermolene opened this issue Jan 3, 2015 · 5 comments

Comments

@Jermolene
Copy link
Member

As discussed in #1306, there is an inconsistency in that the layout of the plugins folder is different in the repo and in wiki folders. In the repo we have plugins/publisher/name/tiddlywiki.info, while in the wiki folder we have plugins/name/tiddlywiki.info. We should support using the publisher name within wiki folders too.

@hauzer
Copy link

hauzer commented Apr 12, 2015

Continuing from #1652.

I'm aware that it's not a big problem, but the inconsistency is bugging the hell out of me. Would the fix be accepted if I made it backwards compatible? I could make it so that the code checks for plugins at levels one and two deep into the folder hierarchy, excluding folders where a plugin has already been found, for example. Would that make sense? I suppose that some configuration flags for switching the new behavior on/off/exclusive would be useful.

@Jermolene
Copy link
Member Author

Hi @hauzer apologies for the late reply. I'd be delighted to accept a backwards compatible fix. Ideally the pull request would also update the documentation to cover the new layout, mentioning the old layout as deprecated.

@hauzer
Copy link

hauzer commented Apr 23, 2015

Alright, that's good to hear. I'm not sure if I'll have the time to implement this, but I'll drop a pull request if I get it done.

@tobibeer
Copy link
Contributor

What's a "wiki folder"? Would that be an "edition" holding their own plugin folders? Is this still relevant?

@chris2fr
Copy link

Note two mailing list discussions around this issue:

https://groups.google.com/d/msg/tiddlywikidev/jrfSSev1j7A/9fmtADyMAgAJ

https://groups.google.com/d/msg/tiddlywiki/dS_cv-W6y_Y/RD-1y4LtAgAJ

Pull request to formulate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants