Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request : add create tiddler function if 0 result searching #1801

Closed
silvyn opened this issue Jun 19, 2015 · 15 comments
Closed

Feature Request : add create tiddler function if 0 result searching #1801

silvyn opened this issue Jun 19, 2015 · 15 comments

Comments

@silvyn
Copy link
Contributor

silvyn commented Jun 19, 2015

​Hello,

I don't know if this had ever discuss, but today I would like to have a link or button under search result in sidebar, which can propose me to create tiddler if the result is empty.

(before creating new tiddler, I check if I already have an entry whith the same content).

I think that will be in core.
What do you think ?

@sukima
Copy link
Contributor

sukima commented Jun 19, 2015

I love the idea, I've often thought about the same thing.

@sukima
Copy link
Contributor

sukima commented Jun 19, 2015

I think the line that drives the title is at core/modules/widgets/navigator.js:429

@Jermolene
Copy link
Member

I don't think this would need any JS mods; just a new tiddler button that uses the content of $:/temp/search as the tiddler title, and perhaps only reveals itself if the field is not empty. It could be added to the page controls toolbar.

@pmario
Copy link
Member

pmario commented Jun 19, 2015

hmm. If the search result field is empty. right?

@pmario
Copy link
Member

pmario commented Jun 19, 2015

I did experiment with the <$keyboard> widget, eg: ctrl+shift+enter could trigger an action-widget event. .. but imo the <$keyboard> widget can't trigger a button event. ... At least I couldn't get it to work properly :/

@Jermolene
Copy link
Member

We should definitely extend the keyboard widget to support action widgets. I think it would open the door to a few interesting shortcuts.

@Jermolene
Copy link
Member

Just to be clear, we're now talking about two different solutions:

  • A button, built on the existing core
  • A keyboard shortcut, requiring an update to the keyboard widget

@sukima
Copy link
Contributor

sukima commented Jun 19, 2015

Should there be another ticket cut for the second line item?

@Jermolene
Copy link
Member

Yes, please :)

@danielo515
Copy link
Contributor

In my opinion this feature already existed , and we "bugfixed" it. Do you remember when the search widget returned a link to the searched term? If you clicked on it, you were asked for creating that tiddler.

@sukima
Copy link
Contributor

sukima commented Jun 20, 2015

@danielo515 can you elaborate? I don't see any thing close to that at tiddlywiki.com's search results. Clicking the search icon opens the "Advanced Search" tiddler and clicking the plus button opens a "New Tiddler".

@danielo515
Copy link
Contributor

Hello @sukima

As I said, it is not in place anymore. It was on previous versions of TW. Try making a search on 5.1.5 for example. You will get a link to a non existing tiddler.

@pmario
Copy link
Member

pmario commented May 28, 2018

@silvyn ... I did create a little plugin: https://wikilabs.github.io/editions/new-tiddler-from-search/

Please test and close the issue if you are OK.

If not, please respond too!

@silvyn
Copy link
Contributor Author

silvyn commented May 28, 2018

Hi @pmario and thanks for this proposal.
It's interesting, and I can do work with that.
Maybe the tag fields is not necessary here (or if we could use auto-completion it will be better, but not so simple, so I think I'll disable it to be sure of name tag (or just ignore it).

@pmario
Copy link
Member

pmario commented May 28, 2018

If the plugin is OK for you, you should close the issue.

@silvyn silvyn closed this as completed May 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants