Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wikitext for default highlight: @@highlight@@ #2228

Closed
twMat opened this issue Jan 16, 2016 · 12 comments
Closed

Add wikitext for default highlight: @@highlight@@ #2228

twMat opened this issue Jan 16, 2016 · 12 comments

Comments

@twMat
Copy link
Contributor

twMat commented Jan 16, 2016

@@background:yellow; content@@ works but there is no default option without parameters.

I propose @@content@@ as a quick way to get the typical faint(!) yellow background on the content.

@tobibeer
Copy link
Contributor

I'd agree that such a basic highlight is useful.

@twMat
Copy link
Contributor Author

twMat commented Apr 9, 2020

bump

@twMat twMat changed the title Add wikitext for default highligt: @@highlight@@ Add wikitext for default highlight: @@highlight@@ Apr 9, 2020
@linonetwo
Copy link
Contributor

So you mean transform @@background:yellow; content@@ to a span tag, and @@content@@ to mark tag.

@pmario
Copy link
Member

pmario commented Apr 17, 2020

@linonetwo ... @@ is about Styles and classes ... imo not the same as <mark>

@linonetwo
Copy link
Contributor

You are right, @@ only add style or class to the outer element, not adding a warper element.

Maybe @@highlight@@ can add a special highlight class, that can be config in the palette.

@pmario
Copy link
Member

pmario commented Aug 4, 2022

I think the OT is actionable and imo makes sense, so I'll bump the issue

@Jermolene
Copy link
Member

It's a good idea. I don't think there are any backwards compatibility considerations because @@foobar@@ at present doesn't do anything useful.

@twMat
Copy link
Contributor Author

twMat commented Aug 4, 2022

So no misunderstanding: I'm hoping it will work also for @@strings with spaces@@

@pmario
Copy link
Member

pmario commented Aug 4, 2022

So no misunderstanding: I'm hoping it will work also for @@Strings with spaces@@

Yes is will. It's like any other "emphasis" rule we have eg: bold

@pmario
Copy link
Member

pmario commented Dec 8, 2023

@twMat -- IMO this one can be closed -- The default colour has been implemented some time ago. See: https://tiddlywiki.com/#Formatting%20in%20WikiText

@linonetwo
Copy link
Contributor

I see, it generates <span class="tc-inline-style">highlight</span> where tc-inline-style can be moded.

@Jermolene
Copy link
Member

Thank you @pmario

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants