Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Palette switcher preview doesn't work with indirect colours #4755

Closed
Jermolene opened this issue Jul 14, 2020 · 4 comments
Closed

[BUG] Palette switcher preview doesn't work with indirect colours #4755

Jermolene opened this issue Jul 14, 2020 · 4 comments

Comments

@Jermolene
Copy link
Owner

The preview swatches in the palette switcher in control panel do not correctly show colours that are defined indirectly via the <<colour>> macro

Steps to reproduce the behavior:

  1. Go to https://tiddlywiki.com/
  2. Click on the cog icon to open the control panel, and choose the "Appearance" and then "Palette" tabs
  3. Scroll down to the "Show Editor" button and click it
  4. Locate the entry for "General Background"/"background" (which should currently be set to #ffffff)
  5. Change it to <<colour alert-background>>
  6. Note that the background colour of tiddlers changes to yellow, and
  7. The error is that the preview swatch should show the background colour as the second box, but it doesn't show the correct yellow colour

image

This behaviour is observed on all platforms.

@Jermolene
Copy link
Owner Author

@BurningTreeC I wondered if you'd be able to kindly look at this?

@Jermolene
Copy link
Owner Author

I should have added a link to a Google Group discussion where this issue is raised:

https://groups.google.com/d/msgid/tiddlywiki/52e787ec-eb8a-429c-8c83-c895a016fed1o%40googlegroups.com

@BurningTreeC
Copy link
Contributor

@Jermolene yes I can have a look when I have time

@Jermolene
Copy link
Owner Author

Thanks @BurningTreeC

BurningTreeC added a commit to BurningTreeC/TiddlyWiki5 that referenced this issue Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants