Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] toc-macros produce whitespace in the DOM because \whitespace trim is missing #6782

Closed
pmario opened this issue Jul 14, 2022 · 3 comments · Fixed by #6825
Closed

[BUG] toc-macros produce whitespace in the DOM because \whitespace trim is missing #6782

pmario opened this issue Jul 14, 2022 · 3 comments · Fixed by #6825

Comments

@pmario
Copy link
Contributor

pmario commented Jul 14, 2022

Describe the bug

toc-macros produce whitespace in the DOM because \whitespace trim is missing

See the screenshot. It's a bit hard to see, but there is some leading whitespace, that causes the underline on hover to be too long.

Expected behavior

No response

To Reproduce

Visit: https://tiddlywiki.com/#Table-of-Contents%20Macros%20(Examples)
and select the Expadable tab. See screenshot

Screenshots

image

TiddlyWiki Configuration

v5.2.2 windows FF

Additional context

No response

@pmario
Copy link
Contributor Author

pmario commented Jul 14, 2022

I think, we should use \whitespace trim for all macro definitions in https://tiddlywiki.com/#%24%3A%2Fcore%2Fmacros%2Ftoc ... A bit of testing will be needed.

@pmario
Copy link
Contributor Author

pmario commented Jul 25, 2022

I'm preparing a PR

@Jermolene
Copy link
Owner

Thanks @pmario

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants