-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] $:/core/ui/PageTemplate/story Caught in a dead loop on entry #7579
Comments
As a workaround you can open the tiddler and set the field |
If you change something in the story template and save it, you'll see it immediately once you save it. So the preview IMO is not needed anyway. I usually open UI template tiddlers to see the code and not to see a preview. |
The solution is indeed this, but this is only because this entry is relatively small. If this entry had a lot of content, it would be stuck in an unclickable state. See the forum discussion at . |
@Jermolene -- It seems the recursion-protection fails with v5.3.0. |
Hi @dongrentianyu @pmario the recursion protection is working as intended here: a fixed number of recursive transclusions are allowed, but once they reach that number further transclusions are disabled. Prior to v5.3.0 a different recursion detection mechanism was used, that worked by preventing repeated nested transclusions with the same parameters. The advantage of the old approach was that it would cut off recursions like the OP immediately. The trouble was that the old mechanism couldn't detect many types of infinite recursion. The new mechanism just relies of detecting excessive stack growth, and is robust. It is possible that we should reduce the maximum allowed depth, which is currently set to 1000: TiddlyWiki5/core/modules/widgets/widget.js Lines 15 to 16 in 0c64b58
In any event, I think the OP here is really about the failings of the current view template body cascade filter for the code body view. The filter is currently:
Broken up to be more readable:
The trouble is the run Perhaps the best fix would be to switch from using the cascade to using an explicit
|
It looks like there is a protection mechanism in place, I was overly concerned. |
There are 280 tiddlers that match the filter: I did create a button that can open all of them. Important: This button will brick your wiki, without the new cascade tag-filters and
There are 10 of them which need a
The rest of them can be covered with tag filters
With those settings applied, the button will work fine and IMO the "view state" works as intended. PR will follow soon. |
Closed in #7583 |
Describe the bug
When you enter this entry, it gets stuck in a dead loop, but the page still loads out without getting completely stuck and unclickable.
Would it be considered to add a code-body field and set the value to yes to prevent this error from occurring.
The loss would be that we wouldn't be able to see this entry displayed. So the further question is how to display it only once and not get stuck in a dead loop.
Expected behavior
No response
To Reproduce
No response
Screenshots
TiddlyWiki Configuration
Additional context
No response
The text was updated successfully, but these errors were encountered: