Allow widget actions to propagate to children

[ng110]

Modified invokeActions() in widget.js to recursively propagate action trigger event to all descendants. Maintains compatibility with call from button widget.

Modified select.js to add action triggering capability. Requires the widget.js modification to work.

[tobibeer]

@ng110 — don't exactly know why exactly but someone once quite emphasized never to pull on master #1371 (comment) ...so, I believe you're going to have to close this one and create a branch.

[tobibeer]

hi @ng110, what I don't think your code handles is the case of there being html elements, so if you want that code to recursively traverse down the dom, you will have to wrap the recursion in a function and also call it on any html elements that act as intermediary wrappers, so as to check their children for action widgets

[Jermolene]

@ng110 it's OK to send a pull request on your master, but it means that you'll need to create a fork for any further unrelated modifications you might make.

There is still an unresolved problem with extending the select widget to invoke action widgets, which is that the there will not have been a refresh cycle to propogate the new value of the select widget. (I saw some discussion on another ticket or in the groups, but can't find the reference).

The best approach might be to separate the modification to the select widget into a separate pull request. I'll merge the propogation change and then we can address the select widget issue.

[ng110]

Yes there was discussion on the refresh issue in the thread on the group that lead me into working on this. I didn't go on to look at that matter though because I solved my immediate problem with a bespoke widget, and life got in the way of doing more general purpose solutions.

Cheers,

Neil.

---- On Tue, 27 Jan 2015 13:07:39 +0000 Jeremy Ruston<notifications@github.com> wrote ----

@ng110 it's OK to send a pull request on your master, but it means that you'll need to create a fork for any further unrelated modifications you might make.
There is still an unresolved problem with extending the select widget to invoke action widgets, which is that the there will not have been a refresh cycle to propogate the new value of the select widget. (I saw some discussion on another ticket or in the groups, but can't find the reference).
The best approach might be to separate the modification to the select widget into a separate pull request. I'll merge the propogation change and then we can address the select widget issue.
—
Reply to this email directly or view it on GitHub.

[Jermolene]

@ng110 are you in a position to revise the pull request by removing the modification to the select widget? It'll leave a more confusing history if I merge the entire PR and then revoke that change.

[ng110]

@Jermolene: I have committed a reverted select.js. Do I also need to update the pull request or is that automatic?

Would it be better if I also reverted the widget.js change and resubmitted on a separate branch?

N.

[Jermolene]

Hi @ng110 no, this is fine to merge.

[tobibeer]

Not sure if that would ever be needed, but what happens if the action widgets are not immediate children in the dom, but nested in some more html?

[Jermolene]

As long as they are descendents in the widget tree then they'll be triggered.

[tobibeer]

Ok, thanks.