Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RevealWidget state can be a text reference #1721

Merged
merged 1 commit into from
May 12, 2015
Merged

RevealWidget state can be a text reference #1721

merged 1 commit into from
May 12, 2015

Conversation

rubaboo
Copy link
Contributor

@rubaboo rubaboo commented May 10, 2015

Reveal widget accepts a text reference for the state attribute.

@inmysocks
Copy link
Contributor

You may want to have 'Title or TextReference' so that it is clear for people who aren't sure what a TextReference is. The idea took me an almost embarrassingly long time to understand.

@rubaboo
Copy link
Contributor Author

rubaboo commented May 10, 2015

That would be redundant though. TextReference was pretty clear to me. :)
On May 10, 2015 7:06 AM, "jed" notifications@github.com wrote:

You may want to have 'Title or TextReference' so that it is clear for
people who aren't sure what a TextReference is. The idea took me an almost
embarrassingly long time to understand.


Reply to this email directly or view it on GitHub
#1721 (comment)
.

@Jermolene
Copy link
Owner

Thanks @nameanyone

Jermolene added a commit that referenced this pull request May 12, 2015
RevealWidget state can be a text reference
@Jermolene Jermolene merged commit 04d293b into Jermolene:master May 12, 2015
@danielo515
Copy link
Contributor

I have to agree that it is not as clear as it should. If it is possible to use a text reference or just a title of the tiddler containing the text then both options should be explained. If you think that the idea of a text reference includes this already then maybe you are too familiar to TW concepts

@rubaboo
Copy link
Contributor Author

rubaboo commented May 14, 2015

@danielo515
I don't have to think. It's spelled clearly in the first bullet point in TextReference. That's just one click away, please have a look at the updated RevealWidget. It's consistent with the rest of the documentation that is peppered with similar references to concepts.

@Jermolene
What I find not clear in TextReference is the use of angle brackets as a "meta" quoting symbol. Since angle brackets are already widely used it TiddlyWiki for widgets, macros and html tags, it took me a try to realize that they should not be taken literally here.

@Jermolene
Copy link
Owner

What I find not clear in TextReference is the use of angle brackets as a "meta" quoting symbol. Since angle brackets are already widely used it TiddlyWiki for widgets, macros and html tags, it took me a try to realize that they should not be taken literally here.

That's a good point @nameanyone, thanks.

Jermolene pushed a commit that referenced this pull request May 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants