Blob api #173
Merged
Blob api #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should fix crashing on large wikis under chrome see chrome bug: https://code.google.com/p/chromium/issues/detail?id=103234 This should also speed up generating the download html by a couple of seconds it avoids repeatedly marshalling the base64 encoded href string across the sandbox boundary it avoids some time and memory consumed by "large" dom manipulation major remaining delay is in encodeURIComponent TODO: consider using iconv on the server TODO: consider async invocation of regular expressions to avoid client "lockup" Conflicts: core/modules/savers/download.js
We don't need to encodeURIComponent at all when using blob links. The data never goes into the dom directly, just a guid reference. This makes saving with blobs very fast!
Jermolene
pushed a commit
that referenced
this pull request
Oct 1, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #159