Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make rsod less annoying #2799

Merged
merged 2 commits into from
May 10, 2018
Merged

Conversation

pmario
Copy link
Contributor

@pmario pmario commented Mar 8, 2017

There are some good argument in this discussion, to make the js error form more user friendly.

  • I did reorganize the CSS a bit.
  • centering the form is easier now.
  • form is max 80% high
  • error-message has overflow auto, so scroll bars will be used if needed.
  • error-message text got its own class name.
  • did remove the text shadow, since it creates very hard to read text

@tejjyid
Copy link
Contributor

tejjyid commented Mar 8, 2017

I agree! This is a more sophisticated implementation than my own personal hack.

@sukima
Copy link
Contributor

sukima commented Mar 8, 2017

For reference this is what it looks like in Chrome:

screen shot 2017-03-08 at 08 22 33

edit: Updated screen shot

@pmario
Copy link
Contributor Author

pmario commented Mar 8, 2017

the advantage can be seen if you have a lot of text. The cancel button will not be moved out of view. Which actually was the reason, for me, to make the PR,

@sukima
Copy link
Contributor

sukima commented Mar 8, 2017

@pmario Updated the screenshot with more text.

While we are at it any chance we could change the color of the button text? White on white looks bad. Glad there is only one button!

@BurningTreeC
Copy link
Contributor

@Jermolene - could this be added to 5.1.17?

@Jermolene Jermolene merged commit 7468ad7 into Jermolene:master May 10, 2018
@pmario pmario deleted the make-RSOD-less-annoying branch May 10, 2018 22:55
ldorigo pushed a commit to ldorigo/TiddlyWiki5 that referenced this pull request Jun 10, 2018
* give js-error form its own CSS rules. error form should not exceed screen size

* fix whitespace
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants