Table valign #321
Table valign #321
Conversation
|
Fast work @Skeeve! wd! There are some further thoughts regarding the use of extra extension formatting characters for tables. These relate to @Jermolene's suggestion to consider multiline tables at the last Hangout (30th Dec). Please could we hold off committing to the latent documentation of table syntax until we can discuss the options at the next Hangout (7th Jan)? |
|
You'd better ask Jeremy. |
|
Hi @Skeeve. The comment was destined for Jeremy in case he plans any pulls; of course, he'll automatically see it as a result of having being tagged @Jermolene. |
| @@ -64,6 +76,16 @@ var processRow = function(prevColumns) { | |||
| // Look for a space at the start of the cell | |||
| var spaceLeft = false, | |||
| chr = this.parser.source.substr(this.parser.pos,1); | |||
| var vAlign = null; | |||
| if (chr === "^") { | |||
There was a problem hiding this comment.
Hi @Skeeve there's a few coding style inconsistencies. I'll clean them up but would appreciate attention to them - thank you!
There was a problem hiding this comment.
Am 03.01.14 11:34, schrieb Jeremy Ruston - notifications@github.com:
In core/modules/parsers/wikiparser/rules/table.js:
@@ -64,6 +76,16 @@ var processRow = function(prevColumns) {
// Look for a space at the start of the cell
var spaceLeft = false,
chr = this.parser.source.substr(this.parser.pos,1);
var vAlign = null;if (chr === "^") {Hi @Skeeve https://github.com/Skeeve there's a few coding style
inconsistencies. I'll clean them up but would appreciate attention to
them - thank you!—
Reply to this email directly or view it on GitHub
https://github.com/Jermolene/TiddlyWiki5/pull/321/files#r8631814.Could you please tell me what was inconsistent? I thought everything was
fine.
There was a problem hiding this comment.
The try/catch is fixed in 8fc5c1d
Fixing issue #314 and issue #315
Adding valignment using ^ and ,
Adjusting the documentation
@jeremy: check the top of the ".tid" file as I did not change the metadata of the documentation tiddler.