-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add outline-color to button, textarea, input #3822
Conversation
Thanks @BurningTreeC I'm nervous about including a colour that isn't defined in the core palettes because it makes it so hard for people to find. I also wonder whether "outline" is the right name; we use "border" for other things. Perhaps it should be "control-border"? |
should we just use the primary color? |
The primary colour is supposed to be a prominent highlight colour. Perhaps the "muted-foreground" colour? |
I see the outlining mostly used to highlight the element that has focus, so the primary color would match for that purpose. For me it should just match the palette and I'm fine with muted-foreground |
I'd misunderstood; the primary colour would indeed be a reasonable choice. |
changed to use primary @Jermolene |
Thanks @BurningTreeC |
* add outline-color to button, textarea, input * add select elements, move to top * use primary color
No description provided.