Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add outline-color to button, textarea, input #3822

Merged
merged 3 commits into from
Mar 3, 2019

Conversation

BurningTreeC
Copy link
Contributor

No description provided.

@Jermolene
Copy link
Member

Thanks @BurningTreeC I'm nervous about including a colour that isn't defined in the core palettes because it makes it so hard for people to find. I also wonder whether "outline" is the right name; we use "border" for other things. Perhaps it should be "control-border"?

@BurningTreeC
Copy link
Contributor Author

I'm nervous about including a colour that isn't defined in the core palettes because it makes it so hard for people to find. I also wonder whether "outline" is the right name; we use "border" for other things. Perhaps it should be "control-border"?

should we just use the primary color?

@Jermolene
Copy link
Member

The primary colour is supposed to be a prominent highlight colour. Perhaps the "muted-foreground" colour?

@BurningTreeC
Copy link
Contributor Author

Perhaps the "muted-foreground" colour?

I see the outlining mostly used to highlight the element that has focus, so the primary color would match for that purpose.

For me it should just match the palette and I'm fine with muted-foreground

@Jermolene
Copy link
Member

I see the outlining mostly used to highlight the element that has focus, so the primary color would match for that purpose.

I'd misunderstood; the primary colour would indeed be a reasonable choice.

@BurningTreeC
Copy link
Contributor Author

changed to use primary @Jermolene

@Jermolene
Copy link
Member

Thanks @BurningTreeC

@Jermolene Jermolene merged commit 0b1ce30 into TiddlyWiki:master Mar 3, 2019
@BurningTreeC BurningTreeC deleted the patch-96 branch March 3, 2019 21:23
jho1965us pushed a commit to jho1965us/TiddlyWiki5 that referenced this pull request Apr 3, 2019
* add outline-color to button, textarea, input

* add select elements, move to top

* use primary color
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants