-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CheckBox.tid #3996
Update CheckBox.tid #3996
Conversation
Thanks @twMat |
@Jermolene - Forgive me, this PR was an error. Please revoke. However, the example, as found at very bottom in https://tiddlywiki.com/prerelease/#CheckboxWidget does not work correctly. The added tags are faulty. |
It takes the tags from "Features" and "Encryption" and applies them to the current (CheckBoxWidget) tiddler.
After 2.5 years, I have no idea why this 2nd clause is in there, nor how it escaped testing. Apologies :$ |
Thanks @Marxsal. I'm actually inclined to remove the example entirely since it doesn't really demonstrate the checkbox widget and is overly complex. |
But the actions (and uncheckactions) attributes are really important and they are by necessity more complex than the the other attributes. An example is absolutely needed IMO. However, maybe it is possible to externalize the argument into a macro, to make the example clearer? |
I couldn't come up with a good example in reasonable time. I don't consider it a particularly useful feature: we already have adequate bindings between the checkbox and the tiddler store, and I struggle to see scenarios where the action string attribute is useful. |
Are you implying one should use other means, presumably then the ButtonWidget, instead of the checkbox when further actions are needed? And then even a second button for uncheckactions....? |
Currently you can use "tag" and "untagged" to flip the presence of a tag in a tiddler. A plausible real-life example where the actions attribute is needed is when you want there to also be an "untagged" Tag that is added when unchecked and taken away when checked. |
If we need real-life examples I refer to the fields2table macro that I released just the other day. The table "edit toggle" is a styled checkbox that performs multiple actions on both check and uncheck. The option would be two buttons and two reveal widgets. |
Thanks @Marxsal @twMat that's helpful.
In that situation one would try to avoid using the "untagged" tag and instead dynamically read the untagged tiddlers with the
It's great that it's been convenient, but I don't think that that would be concise enough for the sort of example we want here. |
No description provided.