New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make filter operater examples live-editable #6139
Make filter operater examples live-editable #6139
Conversation
…earch to make input wider
@btheado I think that a demo is needed to really be able to understand this PR. Could you upload a file somewhere and link to it please? TiddlyHost.com or Github pages would do the trick. |
@saqimtiaz, I published a demo at http://btheado.github.io/TiddlyWiki5/filter-examples-demo.html. Two tiddlers are displayed by default. The first one has pre-loaded |
@@ -110,6 +110,9 @@ td svg { | |||
padding-bottom: 0; | |||
margin-top: 0.2em; | |||
} | |||
.doc-example input { | |||
width: 60%; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I personally would prefer it to be 100%. There are a lot of examples that are cut off ..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@btheado this rule is making checkboxes in other documentation examples not display properly, see https://tiddlywiki.com/#CheckboxWidget (As reported by @twMat)
input[type='search']
might be what we need here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, good team work :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Jermolene This PR undoes the changes that have been added by: "Increase specificity of style doc-examples input" #6174 ... So now in https://tiddlywiki.com/prerelease/#CheckboxWidget the formatting of the checkbox widget is broken. The style that should be used is: .doc-example input[type=search]
... as defined in #6174
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Jermolene This PR undoes the changes that have been added by: "Increase specificity of style doc-examples input" #6174 ... So now in https://tiddlywiki.com/prerelease/#CheckboxWidget the formatting of the checkbox widget is broken. The style that should be used is:
.doc-example input[type=search]
... as defined in #6174
I think the tiddlywiki-com branch just needs to be merged into master.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea, Sorry thought about this too after checking the timing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks – I've just pushed an update
I think that's a really cool improvement! It looks good from my point of view |
This is great, thanks @btheado, and thank you @saqimtiaz and @pmario |
@Jermolene can we do some git magic and get this working in the pre-release as well? |
Good thinking, I've just pushed an update to "master" |
The filter operator examples can be executed by clicking the "Try It" button. Change this button so it also converts the filter text into an
$edit-text
widget. This way the filter examples can be changed on-the-fly.Some notes:
I used this wikitext to display all the filter operator examples so I could easily test many of them: