Support case insensitive matching in prefix/suffix operators

[benwebber]

Support caseinsensitive/caseinsensitive suffixes in the following filter operators:

• prefix
• suffix
• removeprefix
• removesuffix

The suffixes have the same behaviour as the match operator.

Closes: #6407

---

The existing case sensitivity blurb for the match operator works with for these filters as well. Maybe we can extract it as its own tiddler?

[saqimtiaz]

Thank you @benwebber
Could you please also add some tests for the operators that now have new suffixes? The existing tests for the prefix operator can be found here:
https://github.com/Jermolene/TiddlyWiki5/blob/master/editions/test/tiddlers/tests/test-filters.js#L270

The tests can be run via tiddlywiki editions/test

[benwebber]

Ran into something adding the test cases. What is the expected behaviour of removeprefix and removesuffix if the parameter is the empty string? Currently they act differently.

removeprefix does not filter the input:

ABCDE abcde +[removeprefix[]]

ABCDE abcde

Whereas removesuffix discards all titles:

ABCDE abcde +[removesuffix[]]

Intuitively, I would expect removesuffix to behave like removeprefix.

EDIT: prefix and suffix exhibit the same behaviour.

ABCDE abcde +[prefix[]]

ABCDE abcde

---

ABCDE abcde +[suffix[]]

[saqimtiaz]

Ran into something adding the test cases. What is the expected behaviour of removeprefix and removesuffix if the parameter is the empty string? Currently they act differently.

That is almost surely not intentional, however we now have to consider the problem of keeping the code backwards compatible. I am personally tempted to correct the behaviour of removesuffix[] so that it does not filter the list and remove all items when called with an empty string as operand. Thoughts @Jermolene ?

[Jermolene]

Thanks @benwebber @saqimtiaz

I am personally tempted to correct the behaviour of removesuffix[] so that it does not filter the list and remove all items when called with an empty string as operand. Thoughts @Jermolene ?

I think that makes sense.

[benwebber]

Great. suffix has the same behaviour, should we change it too?

[saqimtiaz]

Great. suffix has the same behaviour, should we change it too?

Yes please.

[saqimtiaz]

bump

[Jermolene]

Great stuff, thanks @benwebber