-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Give plugin authors the chance to extend a palette #6624
Conversation
bad idea @Jermolene ? |
Hi @BurningTreeC I think this approach only allows one plugin to provide extensions for any particular palette. We should always be trying to minimise the chance of conflicts between plugins. An approach that allows plugins to provide entries for particular palettes without conflicting with one another might be to support config tiddlers of the form
The only conflicts with that design is if two plugins try to set the same entry for the same palette, but that's an intrinsic conflict that we can't resolve. |
Hi @Jermolene , I've changed it as you said |
Thanks @BurningTreeC I meant to add that we should also take this opportunity to replace the text substitution usage of this macro, please. |
Thanks @Jermolene , I've updated everything accordingly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @BurningTreeC just a minor point.
Thanks @BurningTreeC |
This reverts commit b3b3020.
@BurningTreeC I have reverted this commit because it completely breaks colour handling: Did you test it before submission? |
Apologies @Jermolene - I tested it but there's one small typo |
This PR changes the
colour
macro so, that it transcludes a tiddler with the name of the current palette but with the suffix/extension
on the second positionThis gives plugin authors the chance to extend palettes