Various accessibility improvements #6742
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is your PR related to a problem? Please describe.
As a screen reader user, TiddlyWiki poses some challenges to me:
Describe the solution you are proposing
region
role with anaria-label
caption.switch
role, andaria-checked="true"
is set on whichever is selected. To my screen reader, these now present as checkboxes/switches. I preferred this to ARIA's tabs because the latter implies changing keyboard navigation, and I felt this solved the problem I experienced in the simplest way.article
role. This not only makes it easier to navigate between individual stories, but by announcing region transitions, screen readers now inform about the presence of multiple stories and their boundaries.main
role, making it easier to jump to the river as a whole for screen readers that support it.Describe alternatives you've considered
There really aren't any. We can certainly shuffle things around, and more can be added, but something that creates and updates walls of text really needs regions and labels to make it more navigable.
Additional context
I still need to do more, but this is a lot more usable and I intend to rebuild my wikis on this foundation as soon as it's merged.
I'm not sure how to check compliance with coding style, but I did try. Also not sure to what extent I should test the setting of
aria-checked
--I did set that attribute in a block that appears to trigger on selected state being true. Advice welcome.Checklist before requesting a review