fix problem with hidden preview DOM structure #7057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The wiki in the ZIP should look like this:
|
|
Hi Mario New fix 5.2.4p Old 5.2.3 I think the row height is different and new fix creates taller rows. Other properties seem the same. |
Jermolene
added a commit
that referenced
this pull request
Nov 23, 2022
…em. fix problem with control-panel basics tab shown in story river (#7039)"" See #7057 (comment) This reverts commit fba9efc.
Done |
It's intended, that the row height is a little bit higher. See the problems in the tables described at: #6912 Got to tiddlywiki.com and have a look at all the control-panel tables. All the spacing in the content edit inputs is way to small. It doesn't look good, which has been pointed out several times here at GH and at Talk |
FlashSystems
pushed a commit
to FlashSystems/TiddlyWiki5
that referenced
this pull request
Dec 3, 2022
…em. fix problem with control-panel basics tab shown in story river (Jermolene#7039)"" See Jermolene#7057 (comment) This reverts commit fba9efc.
FlashSystems
pushed a commit
to FlashSystems/TiddlyWiki5
that referenced
this pull request
Dec 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kookma @saqimtiaz please test the wiki in the ZIP .. It contains fixes to issue #7056 AND it also contains the changes PR #7039, which IMO have been reverted without any need.
fix-7056-import-visual-glitch.zip <------------------ Test me
This is the fix to the real problem that my PR #7039 made visible. ...
The problem was the "preview element" it added visibe TR and TD elements to the DOM with a hidden content DIV. Since the TD had some padding from #7039 it was visible.
This PR fixes: [BUG] Visual regression in import table in 5.2.4 pre-release #7056 .
@Jermolene please reapply PR #7039 and then this PR.
There should be no visual glitches anymore. My PR didn't cause the problem it made it visible