Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tiddler icon size #7619

Merged
merged 2 commits into from Jul 21, 2023
Merged

Fix tiddler icon size #7619

merged 2 commits into from Jul 21, 2023

Conversation

Jermolene
Copy link
Owner

As reported in the forum:

This observation is nitpicky and of low priority if considered a bug at all, but looks like an overlook, so I decided to ask.

The icon displayed in front of the tiddler title in the ViewTemplate has fixed, not relative, size. It stays the same size regardless of the title font size.

This is not visible at all on the default font size $:/themes/tiddlywiki/vanilla/metrics/fontsize of 14px, because the fixed size happens to be the same or very similar to the view toolbar icons. It is also not very apparent on small changes of the font size. Bigger changes of the font size, as in screenshots below, demonstrate the problem:

@vercel
Copy link

vercel bot commented Jul 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
tiddlywiki5 ✅ Ready (Inspect) Visit Preview Jul 20, 2023 4:39pm

@pmario
Copy link
Contributor

pmario commented Jul 20, 2023

IMO that's not a fix. It breaks the existing default behaviour.

See: tiddlywiki.com -- HelloThere -- 100% browser zoom

image

See preview -- HelloThere -- 100% browser zoom

image

@pmario
Copy link
Contributor

pmario commented Jul 20, 2023

IMO if you set both to 1em; it would scale in the same amount as the font-size

@Jermolene
Copy link
Owner Author

Thanks @pmario fix upcoming. We seem to need 0.9em to match the existing size

@pmario
Copy link
Contributor

pmario commented Jul 20, 2023

Thanks @pmario fix upcoming. We seem to need 0.9em to match the existing size

Yea, that's the problem with em CSS scaling if there are several elements that use em it gets unpredictable values.
That's why everyone prefers to use rem for new CSS projects now, because it always starts at the initial value.

@Jermolene Jermolene marked this pull request as ready for review July 21, 2023 13:44
@Jermolene Jermolene merged commit fd8b8f6 into master Jul 21, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants