Fix list widget bug with counter-last when appending items #7712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The failing test appends a value to a list without changing the rest of the list, and the counter-last value doesn't get updated correctly when that happens. Also added another test, which passes, testing removing the last item of the list, just in case of a regression.
The unit tests were looking very similar to each other, so I factored out the common code and made them into simple data-driven tests.
The only scenario that was failing was when counter-last was used, but the list was strictly appended to with no other changes made. The one unit test that was failing now passes with this fix.
Now we only refresh the last item if it was truly necessary.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
rmunn
added a commit
to rmunn/TiddlyWiki5
that referenced
this pull request
Sep 5, 2023
The bugfix in this PR is now identical to the bugfix from PR Jermolene#7712 so that we won't get merge conflicts no matter whether that PR or this one is merged first.
|
Thanks @rmunn |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains just the bugfix from #7694 with no new features added to the list widget.
Fixes #7693.