Test if selectedNode.offsetLeft is 0 when dragging a dom node #7714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this adds a necessary test in the edge-case that the offsetLeft property of the selectedNode is 0. It can be zero. For domNode.offsetWidth this test should be superfluous
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Is there a related issue? |
|
Hi @pmario , there's no GitHub issue that's related but I've encountered an issue with this on https://burningtreec.github.io/tiddlywiki-multi-columns The problem can be reproduced if one configures the layout in the ControlPanel (Appearance > MultiColumn) so that the story-rivers have no padding (0) In that case, when you drag a tiddler, at dragstart the variables don't get collected (like the selectedNode's height) and you can see that the dragover-animations don't work |
|
That is because |
|
Thanks @BurningTreeC I've pushed an alternate fix in de6b866 |
munnox
pushed a commit
to munnox/TiddlyWiki5
that referenced
this pull request
Dec 24, 2023
Alternate fix for Jermolene#7714
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this adds a necessary test in the edge-case that the offsetLeft property of the selectedNode is 0. It can be zero. For domNode.offsetWidth this test should be superfluous