Add barcode reader widget to qrcode plugin #7746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Great stuff @linonetwo, I should have been able to guess that this existed. Do you think there are advantages to the library that you chose? |
|
No, seems html5-qrcode is maintained batter https://npmtrends.com/html5-qrcode-vs-jsqr-es6 , I haven't look at html5-qrcode carefully before, otherwise I will choose it too. I will replace my usage with your one, after this is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses the open source library https://github.com/mebjas/html5-qrcode to add barcode reading capabilities to the existing QR code plugin.
It can read barcodes in a wide variety of formats using the device camera or directly from a file.
Try out the preview here