Fixes Text Parser being impacted by overrides to codeblock widget #7844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Great thanks @saqimtiaz |
munnox
pushed a commit
to munnox/TiddlyWiki5
that referenced
this pull request
Dec 24, 2023
…rmolene#7844) * fix: overriding codeblock widget should not impact text parser * fix: whitespace changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue reported in the forum where overriding the codeblock widget with a custom widget impacts transclusions and any other uses of the Text Parser.
The problem is caused by the transclude widget (and thus also by the macrocall widget which is used in the tabs macro) when used with the output type text/plain. The parser that wikifies the variable to retrieve the plain text output wraps the variable in a codeblock
This PR replaces the codeblock widget used in the Text Parser with a genesis widget with the remappable attribute set to "no", to create the codeblock widget, thus rendering it immune to custom widget overrides. A test has been added that fails before the PR is applied.