Fix 8347 tag-picker macro improve tagListFilter #8351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
It is great! Works very well! :-D |
|
Thanks @pmario does this fix a regression in v5.3.4, or is this a new feature? |
@Jermolene -- the tagListFilter parameter is new in v5.3.4 -- So it's more an oversight than a regression since it does not exist in v5.3.3 |
|
Thanks @pmario |
saqimtiaz
reviewed
Jul 10, 2024
| @@ -19,7 +19,8 @@ The <<.def tag-picker>> [[macro|Macros]] generates a combination of a text box a | |||
| : <<.from-version 5.3.4>> Defines the target tiddler, which should be manipulated. Defaults to: <<.var currentTiddler>>. | |||
|
|
|||
| ; tagListFilter | |||
| : <<.from-version 5.3.4>> This parameter defaults to: `[tags[]]` which creates a list of all existing tags. If the tag list should come from a different source the filter should look similar to eg: `[<listSource>get[field-name]enlist-input[]]`. | |||
| : <<.from-version 5.3.4>> This parameter defaults to: `[tags[]]` which creates a list of all existing tags. If the tag list should come from a different source the filter should look similar to eg: `[<listSource>get[field-name]enlist-input[]]`. See examples. | |||
| : <<.from-version 5.3.6>> This parameter defaults to: `[tags[]sort[]]`. This change allows a custom sort order, since `sort[]` is not hardcoded into the tag-picker macro anymore. | |||
There was a problem hiding this comment.
@pmario @Jermolene I assume this a typo and it should state 5.3.5 and 5.3.6?
There was a problem hiding this comment.
Thanks @saqimtiaz I've pushed a fix in 1eb1af2
tsukasa-au
pushed a commit
to tsukasa-au/TiddlyWiki5
that referenced
this pull request
Aug 3, 2024
* improve tagListFiler defaults to [tags[]sort[]] now * tag-picker - update docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #8347 tag-picker macro, change tagListFilter
tagListFilterfrom[tags[]]to[tags[]sort[]]sort[]from the default filters.So users can provide custom filters now.
@twMat Please test the preview, once it is built