Added ThrowingFileFetcher for readability #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbirke
requested changes
May 11, 2017
src/StubFileFetcher.php
Outdated
| * @licence GNU GPL v2+ | ||
| * @author Jeroen De Dauw < jeroendedauw@gmail.com > | ||
| */ | ||
| class NullFileFetcher implements FileFetcher { |
There was a problem hiding this comment.
Class name mismatch with file name.
There was a problem hiding this comment.
:D ... yea, so all code not tested is broken, even if it just is a NullObject >_>
JeroenDeDauw
force-pushed
the
ThrowingFileFetcher
branch
from
b599a8c
to
4f25797
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.