Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added error logging file fetcher #9

Merged
merged 4 commits into from May 9, 2017
Merged

Added error logging file fetcher #9

merged 4 commits into from May 9, 2017

Conversation

JeroenDeDauw
Copy link
Owner

@JeroenDeDauw JeroenDeDauw requested a review from gbirke May 9, 2017 16:43
gbirke
gbirke approved these changes May 9, 2017
View reviewed changes
Copy link
Collaborator

@gbirke gbirke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the configurable log level with error as default.

@JeroenDeDauw JeroenDeDauw merged commit f2401b8 into master May 9, 2017
@JeroenDeDauw JeroenDeDauw deleted the ErrorLoggingFileFetcher branch May 9, 2017 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gbirke gbirke gbirke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JeroenDeDauw @gbirke