Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Update ParserHooks.php" #7

Merged
merged 1 commit into from
Oct 21, 2015
Merged

Revert "Update ParserHooks.php" #7

merged 1 commit into from
Oct 21, 2015

Conversation

JeroenDeDauw
Copy link
Owner

Reverts #4

@JeroenDeDauw
Copy link
Owner Author

Autoloading is done via composer, not manual MediaWiki classmap

JeroenDeDauw added a commit that referenced this pull request Oct 21, 2015
@JeroenDeDauw
Merge pull request #7 from JeroenDeDauw/revert-4-patch-1
aea2c92 
Revert "Update ParserHooks.php"
@JeroenDeDauw JeroenDeDauw merged commit aea2c92 into master Oct 21, 2015
@JeroenDeDauw JeroenDeDauw deleted the revert-4-patch-1 branch October 21, 2015 17:07
@paladox
Copy link
Contributor

paladox commented Oct 21, 2015

Hi it keeps erroring out

17:16:54 PHP Fatal error: Class 'ParserHooks\HookRunner' not found in /mnt/jenkins-workspace/workspace/mwext-ParserHooks-testextension-zend/src/extensions/ParserHooks/tests/phpunit/HookRunnerTest.php on line 26

at https://integration.wikimedia.org/ci/job/mwext-ParserHooks-testextension-zend/11/console

@JeroenDeDauw
Copy link
Owner Author

I'm going to assume this is because the Jenkins setup there is broken. It works on Travis, and I can run the tests locally

@paladox
Copy link
Contributor

paladox commented Oct 21, 2015

Oh jenkins isent broken since it is on Wikimedia. And works with most extensions.

@paladox
Copy link
Contributor

paladox commented Oct 21, 2015

Works with this new test https://integration.wikimedia.org/ci/job/mwext-testextension-zend-composer/173/console

its because Wikimedia haven several test so the zend-composer test works.

@paladox
Copy link
Contributor

paladox commented Oct 21, 2015

@JeroenDeDauw Please can you review https://gerrit.wikimedia.org/r/#/c/247864/ it is to fix jenkins test keep failing and imports code from here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JeroenDeDauw @paladox