Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor JS, remove Browserify, simplify JS for components #31

Merged
merged 1 commit into from Mar 20, 2018

Conversation

krijnhoetmer
Copy link

  • Only 1 JS file per component, aligning with CSS (includes handlers and/or decorators).
  • Less duplicate code (less var dom = require( 'helpers/dom' ); lines; using the ohnl global now (opinionated, I know)).
  • Component JS are included automatically (handlers.js and decorators.js no longer required, no need to manually list all included components - less Naming Things).
  • Handlers/Decorators need to be registered from within each component; duplicates are now logged.
  • All JS is now included in one file (main.js); polyfills is concatenated as well.

@JeroenHulscher JeroenHulscher merged commit 3b33399 into master Mar 20, 2018
@Lesleyvdp Lesleyvdp deleted the remove-browserify branch December 10, 2018 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants