Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ (eslint) NICE-129 continued flat config upgrade #1511

Merged
merged 5 commits into from
Jul 5, 2024
Merged

Conversation

JeromeFitz
Copy link
Owner

@JeromeFitz JeromeFitz commented Jul 5, 2024

typescript-eslint

Continue migration to eslint@9

New Rules

This has the potential to be a b/r/e/a/k/i/n/g change, reason being there seems to be some new rules due to moving packages. Specifically around:

  • @typescript-eslint/consistent-type-definitions: Use an interface instead of a type
  • no-extra-boolean-cast: Redundant double negation
  • no-empty-pattern: Unexpected empty object pattern

These all should probably be fixed but will be ignored for now and addressed later.

Applications importing this package will need to do the same. At the risk of bumping a major every single time we upgrade package(s) from eslint@8 => eslint@9 we are going to use @jeromefitz/eslint-conifg@4 as a holding pattern.

  • Updated README with above

Packages

Add
  • @types/eslint__js
  • @eslint/compat
  • @eslint/js
  • eslint-plugin-import-x (migrated from eslint-plugin-import)
  • typescript-eslint
Remove
  • eslint-plugin-import (migrated to eslint-plugin-import-x)
  • typescript-eslint/eslint-plugin

Please Note: This is continual as the eslint ecosystem continues to slowly (but surely) move to eslint@9. There are some hacks currently to be able to account for config|plugin that are @8. They will continue to be removed / updated.

Refactor

Needed to add back some rules that have gone away from recommended plugins/configs.

Apply Formatting

  • Add @todo(NICE-129) to identify that we should update these, but should not within this PR

Configuration

  • Override @typescript-eslint/parser@7.15.0
  • Renovate: eslint rework
  • Turbo: Move to outputLogs: "new-only" (away from errors-only)

Closes #1507

@JeromeFitz JeromeFitz added the kodiak: merge.method = 'merge' Kodiak: Merge (Override) label Jul 5, 2024
@JeromeFitz JeromeFitz marked this pull request as ready for review July 5, 2024 16:39
@JeromeFitz JeromeFitz added 🥳️ LGTM Automerge: Let's Get This Merged and removed 🥳️ LGTM Automerge: Let's Get This Merged labels Jul 5, 2024
@JeromeFitz JeromeFitz merged commit 2aace54 into main Jul 5, 2024
3 checks passed
@kodiakhq kodiakhq bot deleted the NICE-129 branch July 5, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kodiak: merge.method = 'merge' Kodiak: Merge (Override) 🥳️ LGTM Automerge: Let's Get This Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use typescript-eslint as config and reuse in packages and apps
1 participant