Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ ➕ cmdkkbar ⬆️ @jeromefitz/design-system 💥 [b] #1264

Merged
merged 3 commits into from
Aug 21, 2022

Conversation

JeromeFitz
Copy link
Owner

Still some work to do, but this refactors to use cmdk
with the latest @jeromefitz/design-system@4.0.0.

Coming up would be improved:

  • Menu generation all-around
    • CommandMenu, MobileMenu, NavigationMenu
  • SubItem for root level searching
    • Duplicate pages but block when within page itself
  • Badge Menu system
  • CommandMenu Footer
  • Slight Design & Animation Tweaks
  • CommandMenu Mobile

This would be new PRs so above is just a reference.

Still some work to do, but this refactors to use `cmdk`
 with the latest `@jeromefitz/design-system@4.0.0`.

Coming up would be improved:

- [ ] Menu generation all-around
  - CommandMenu, MobileMenu, NavigationMenu
- [ ] `SubItem` for root level searching
  - Duplicate `pages` but block when within `page` itself
- [ ] Badge Menu system
- [ ] CommandMenu Footer
- [ ] Slight Design & Animation Tweaks
- [ ] CommandMenu Mobile

This would be new PRs so above is just a reference.
@BotJerome BotJerome temporarily deployed to Preview August 20, 2022 11:36 Inactive
@BotJerome BotJerome temporarily deployed to Preview August 20, 2022 12:11 Inactive
@BotJerome
Copy link
Collaborator

This pull request has been deployed to Vercel.

Latest commit: 21a6789
✅ Preview: https://jeromefitzgerald-d115afx28-jerome5.vercel.app
🔍 Inspect: https://vercel.com/jerome/jeromefitzgerald/H8obYSkmpiyVr54QaMQBAHrVyWmL

View Workflow Logs

@JeromeFitz
Copy link
Owner Author

New tasks moved to issue 📝
LGTM 🥳

@JeromeFitz JeromeFitz added the 🥳️ LGTM Automerge: Let's Get This Merged label Aug 21, 2022
@kodiakhq kodiakhq bot merged commit ee23699 into main Aug 21, 2022
@kodiakhq kodiakhq bot deleted the feature/cmdk branch August 21, 2022 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🥳️ LGTM Automerge: Let's Get This Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants