Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ (navigation) cmdk, mobile, navigation #1289

Merged
merged 8 commits into from
Sep 5, 2022
Merged

♻️ (navigation) cmdk, mobile, navigation #1289

merged 8 commits into from
Sep 5, 2022

Conversation

JeromeFitz
Copy link
Owner

@JeromeFitz JeromeFitz commented Sep 5, 2022

Attempt to bubble up one Navigation Data Element that can be used across the board for:

  • Command Menu (cmdk)
  • Mobile Menu (Sheet)
  • Navigation Menu (Desktop)

Commits:

  • 🚧 (cmdk) prep for menu refactor
  • ♻️ (cmdk) menu prep for full site refactor
  • 🔥 MenuKBar
  • ♻️ (cmdk) Dynamic Sub Items 🔥 SubItem, Settings
  • 🚨 (cmdk) fix unused vars and remove unused files
  • ♻️ (menu) 🚚 move files around
  • ♻️ URL_TYPE

@BotJerome BotJerome temporarily deployed to Preview September 5, 2022 21:15 Inactive
@BotJerome BotJerome temporarily deployed to Preview September 5, 2022 21:31 Inactive
@BotJerome
Copy link
Collaborator

This pull request has been deployed to Vercel.

Latest commit: 5cab3a5
✅ Preview: https://jeromefitzgerald-q1w40rr3z-jerome5.vercel.app
🔍 Inspect: https://vercel.com/jerome/jeromefitzgerald/ARafWFJeGRjNkyLQ6XXBFJ7hFGza

View Workflow Logs

@JeromeFitz JeromeFitz added the 🥳️ LGTM Automerge: Let's Get This Merged label Sep 5, 2022
@kodiakhq kodiakhq bot merged commit 40ceeb9 into main Sep 5, 2022
@kodiakhq kodiakhq bot deleted the refactor/cmdk branch September 5, 2022 21:39
@JeromeFitz JeromeFitz mentioned this pull request Sep 7, 2022
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🥳️ LGTM Automerge: Let's Get This Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants