build: add eslint jobs

.circleci/config.yml

@@ -62,6 +62,13 @@ jobs:
       - store_artifacts:
           path: coverage
 
+  eslint:
+    <<: *defaults
+    steps:
+      - attach_workspace:
+          at: ~/repo
+      - run: ./node_modules/.bin/eslint ./src 
+
 workflows:
   build-and-test:
     jobs:
@@ -72,3 +79,6 @@ workflows:
       - test-coverage:
           requires:
             - build
+      - eslint:
+          requires:
+            - build

.eslintrc

@@ -5,7 +5,7 @@
       "sourceType": "module"
     },
     "extends": [
-      "airbnb",
+      "airbnb-base",
       "eslint:recommended"
     ],
     "plugins": [

package.json

@@ -29,10 +29,10 @@
     "ava": "^1.2.1",
     "babel-eslint": "^9.0.0",
     "commitizen": "^3.0.5",
-    "eslint": "^2.13.1",
-    "eslint-config-airbnb": "^9.0.1",
-    "eslint-plugin-import": "^1.12.0",
-    "nyc": "^13.1.0",
+    "eslint": "^5.16.0",
+    "eslint-config-airbnb-base": "^13.1.0",
+    "eslint-plugin-import": "^2.17.2",
+    "nyc": "^14.0.0",
     "pre-commit": "^1.2.2",
     "validate-commit-msg": "^2.14.0"
   },

src/super-cache.js

@@ -63,7 +63,7 @@ function initStorage(ins, storage) {
             set(key, value) {
                 return this.memoryCache[key] = value;
             },
-            remove(key, value) {
+            remove(key) {
                 delete this.memoryCache[key];
             },
             removeAll() {
@@ -82,7 +82,7 @@ function initStorage(ins, storage) {
     else ins.removeData = key => storage.remove.call(ins, `${storage.keyPrefix}:${key}`);
 
     if (typeof storage.removeAll !== 'function') ins.removeAll = () => { throw new Error('storage.removeAll was undefined'); };
-    else ins.removeAll = key => storage.removeAll.call(ins);
+    else ins.removeAll = () => storage.removeAll.call(ins);
 }
 
 /** Class SuperCache. */
@@ -183,7 +183,7 @@ class SuperCache {
 
                 // 其他情况，让外部处理错误
                 throw err;
-            })
+            });
     }
 
     /**