Cleanup of the skin changing system (WIP) [OLD] #63

HoldYourWaffle · 2019-01-20T14:51:25Z

How it works as fast as possible

The capability has an object SkinChangeHandler containing the pixel data on both sides and ResourceLocations on the client
This object is synced normally, if the pixel data changes a new texture is generated & set (this happens in deserilizeNBT, since synchronization always happens server → client so this is the perfect place for it)
For client-side skin choosing (by clicking the reset button or changing skin packs in the future) there's a SkinChange packet that's sent to the server with the new data. The server calls updateServerside on the capabilities skin handler, which sets the new data and synchronizes it to all clients.

TODO

TOTEST

Test multiplayer
Test reset button
Test fallback mechanism

Important notes: - Haven't tested multiplayer - There's currently only 1 skin and it's a hardcoded pathname (nothing random) - Haven't tested the reset skin button - Haven't tested the fallback mechanism - Old classes moved to 'unused' folder because they contain logic I'll still need once I implement it (excuse my english) How it works as fast as possible: - The capability has an object 'SkinChangeHandler' containing the pixel data on both and RL's on the client - This object is synced normally, if the pixel data changes a new texture is generated & set (this happens in deserilizeNBT, synchronization always happens server -> client so this is the perfect place for it) - For client-side skin choosing (by clicking the reset button or changing skin packs in the future) there's a SkinChange packet that's sent to the server with the new data. The server calls SkinChangeHandler.updateServerside which sets the new data and synchronizes it to all clients. While writing this commit message I noticed that I'm not 100% I check *which* player is updated, I assume it takes the player it received the packet from (I might have stolen this code from you).

Jeryn99 · 2019-01-20T14:52:08Z

src/main/java/me/fril/regeneration/RegenConfig.java

@@ -153,7 +153,7 @@

 		@Config.LangKey("config.regeneration.skins.model_preference")
 		@Config.Comment("ALEX = 'Give me Alex Skins only', STEVE = 'Give me Steve Skins only', EITHER = 'Give me either!!'")
-		public SkinChangingHandler.EnumChoices prefferedModel = SkinChangingHandler.EnumChoices.EITHER;
+		public SkinUtil.ModelPreference prefferedModel = SkinUtil.ModelPreference.EITHER; //NOW this probably has to be a capability-level setting (server)


Configs are overwritten when playing on a server

No they aren't

Wait what. I always thought they were as it seems logical, as well as never having issues when playing with friends.
Was this done manually by the mods I played with? How can you prevent cheating if this is the case?

Or wait is it that the serverside logic uses the servers config instance and the client-side logic the client's? That would actually make a lot of sense 🤔

Jeryn99 · 2019-01-20T14:52:52Z

src/main/java/me/fril/regeneration/client/skinhandling/SkinChangeHandler.java

+
+	public void randomizeSkin(Random rand) {
+		if (!cap.getPlayer().world.isRemote)
+			throw new IllegalStateException("Randomizing skin on server");


Why is the skin decided on the server if the clients have the skins?

Wait I misread this, my bad

Read that line again...

Jeryn99 · 2019-01-20T14:54:08Z

src/main/java/me/fril/regeneration/handlers/ActingClientHandler.java

-				RegenerationMod.LOG.error(e.getMessage());
-			}
-		}
+		Minecraft.getMinecraft().getSoundHandler().playSound(new MovingSoundPlayer(cap.getPlayer(), RegenObjects.Sounds.REGENERATION_2, SoundCategory.PLAYERS, true, () -> cap.getState().equals(RegenState.REGENERATING)));


Uhhhhhhh, make sure this get's changed

Whoops that's a conflict thingy

Jeryn99 · 2019-01-20T14:54:59Z

src/main/java/me/fril/regeneration/util/ClientUtil.java

 	public static void sendSkinResetPacket() {
-		NetworkHandler.INSTANCE.sendToServer(new MessageUpdateSkin(new byte[0], isSlimSkin(Minecraft.getMinecraft().player.getUniqueID())));
+		NetworkHandler.INSTANCE.sendToServer(new MessageSkinChange(new byte[0], Minecraft.getMinecraft().player.getSkinType().equals("slim")));


Why didn't I think to do that? haha

Jeryn99 · 2019-01-20T14:56:01Z

unused/SkinChangingHandlerOLD.java

+		File[] files = skins.listFiles(IMAGE_FILTER);
+
+		if (files.length == 0) {
+			//createDefaultImages();


Do re-implement this of course, it stops kids deleting the skins directory and then going "WAAAAAAA WHY DID I CRASH"

Jeryn99 · 2019-01-20T14:56:26Z

unused/SkinChangingHandlerOLD.java

+		if (skinInfo.getSkintype() == SkinInfo.SkinType.ALEX) {
+			SkinChangingHandlerOLD.setPlayerModel(renderPlayer, SkinUtil.ALEX_MODEL);
+		} else {
+			SkinChangingHandlerOLD.setPlayerModel(renderPlayer, SkinUtil.STEVE_MODEL);


I assume this hashmap will be moved to SkinUtil?

As far as I know it's no longer needed. I'm not even sure it was needed in the first place, what was it used for?

Player logs in
They're not in the map
Game: "Oh hey, he hasnt been altered, lets sort that then mark him as altered"

Without it:

Players logs in
Player keeps their Mojang skin

So basically just to make sure everyone gets their skin when they log in? Why would you need the hashmap for that, you could just set the skin in onLogin right?

You're saying that the information get's loaded from the Capability on login and set?

HoldYourWaffle · 2019-01-21T16:42:06Z

New skin changing system

HoldYourWaffle requested a review from Jeryn99 January 20, 2019 14:51

Jeryn99 reviewed Jan 20, 2019

View reviewed changes

Jeryn99 mentioned this pull request Jan 21, 2019

Known issues #64

Closed

19 tasks

HoldYourWaffle changed the title ~~Cleanup of the skin changing system (WIP)~~ Cleanup of the skin changing system (WIP) [OLD] Jan 21, 2019

HoldYourWaffle mentioned this pull request Jan 21, 2019

Cleanup of the skin changing system (WIP) #65

Closed

9 tasks

HoldYourWaffle closed this Jan 21, 2019

Jeryn99 deleted the skinsystem-changes branch April 24, 2019 21:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cleanup of the skin changing system (WIP) [OLD] #63

Cleanup of the skin changing system (WIP) [OLD] #63

HoldYourWaffle commented Jan 20, 2019 •

edited

Loading

Jeryn99 Jan 20, 2019

HoldYourWaffle Jan 20, 2019

nictogen Jan 20, 2019

HoldYourWaffle Jan 20, 2019

HoldYourWaffle Jan 20, 2019

nictogen Jan 20, 2019

Jeryn99 Jan 20, 2019

Jeryn99 Jan 20, 2019

HoldYourWaffle Jan 20, 2019

Jeryn99 Jan 20, 2019

HoldYourWaffle Jan 20, 2019

Jeryn99 Jan 20, 2019

Jeryn99 Jan 20, 2019

HoldYourWaffle Jan 20, 2019

Jeryn99 Jan 20, 2019

HoldYourWaffle Jan 20, 2019

Jeryn99 Jan 20, 2019

HoldYourWaffle Jan 20, 2019

Jeryn99 Jan 20, 2019

HoldYourWaffle Jan 20, 2019

HoldYourWaffle commented Jan 21, 2019

Cleanup of the skin changing system (WIP) [OLD] #63

Cleanup of the skin changing system (WIP) [OLD] #63

Conversation

HoldYourWaffle commented Jan 20, 2019 • edited Loading

How it works as fast as possible

TODO

TOTEST

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

HoldYourWaffle commented Jan 21, 2019

HoldYourWaffle commented Jan 20, 2019 •

edited

Loading