Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated camerax #20

Merged
merged 2 commits into from
Aug 11, 2020
Merged

Updated camerax #20

merged 2 commits into from
Aug 11, 2020

Conversation

tallot13
Copy link
Contributor

@tallot13 tallot13 commented Aug 7, 2020

fixed #15
fixed without access in black layout in cameraview

There is no need to explicitly call CameraX.unbindAll() , since the UseCase is bound to a lifecycle and resources will be automatically freed when the lifecycle reaches the destroyed state. Also, Activity has no onDestroyView method, which is instead owned by Fragments. By the way, for Fragments the proper lifecycle to bind the UseCases to would be the viewLifecycleOwner ‘s lifecycle.

@JessYanCoding JessYanCoding merged commit 1b0762b into JessYanCoding:master Aug 11, 2020
@osama-alshanti
Copy link

same issue,, not getting clear solution

@osama-alshanti
Copy link

osama-alshanti commented Jul 1, 2021

After changing camerax_version & camerax_view like this it's working ..

        camerax_view                  : "1.0.0-alpha10",
        camerax_version               : "1.0.0-beta03",

@HaXxanParhar
Copy link

After changing the camerax_version & camerax_view to @osama-alshanti mentioned versions, I'm having the following errors:
output_camerax

The @osama-alshanti mentioned versions take the File but the original library's versions take ImageCapture.OutputFileOptions. As for the library, I cloned it 2 days ago and using it directly in my existing app. I also added the 'ucrop' & 'picture_library' as modules. I'm updating the versions in the module gradle of 'picture_library'.

@osama-alshanti
Copy link

try @HaXxanParhar use like this mCameraView.takePicture(imageOutFile, ContextCompat.getMainExecutor(getContext()),

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash when pressed take picture button
5 participants