This repository has been archived by the owner on May 24, 2024. It is now read-only.
v1.0.3 #9
Merged
v1.0.3 #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9 +/- ##
===========================================
+ Coverage 99.79% 100.00% +0.20%
===========================================
Files 6 6
Lines 2944 2257 -687
===========================================
- Hits 2938 2257 -681
+ Misses 4 0 -4
+ Partials 2 0 -2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
v1.0.3 brings significant performance improvements. No new features are added.
The
logsubsystem behavior is now less engaged. Users may still supply their own*log.Logger, however no internal use of anylogsystem occurs by default now. Overzealous internal use resulted in significant performance degradation.A (
pprof) performance analysis was done to guide this pull request. Certain inefficiencies were identified and corrected (largely those involving aforementionedloguse).Code coverage remains 100%. Test times dropped from 0.2s to 0.005s on average.