Remove wheels with pandoc included #188
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 13, 2020
We didn't build such wheels for ages and it seems others do it better than us. This lets us get rid of the explicit dependency on pip which is a problem on debian based systems (where pip is disabled).
Still callable as pypandc.ensure_pandoc_installed(), code is replaced with an import from the new place.
jankatins
force-pushed
the
remove_pandoc_included_wheels
branch
from
da873b1
to
26604d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should make both #173 (we suggest that package now) and #159 (the pip dependency is removed) happy. Also makes me happy as the gross hack to implement that feature is now gone.
Closes: #173
Closes: #159