Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added "aarch" type check #303

Merged
merged 3 commits into from
Oct 11, 2022
Merged

Conversation

hey24sheep
Copy link
Contributor

Fixes issue "Platform architecture of ARM Linux system can be aarch64" #293.

@hey24sheep
Copy link
Contributor Author

@JessicaTegner I am sorry for all the mess. I have created another PR from a new branch in hopes it will count. Check & merge it at your leisure, thank you.

@JessicaTegner
Copy link
Owner

fantastic. Are we sure that this will actually work on that platform?

@hey24sheep
Copy link
Contributor Author

I am on windows, so I cannot check that. It only checks if the it starts with 'aarch' as per the given information in the issue. So, it won't break for existing in any case and must work. It's fine to wait for anyone to confirm, no worries.

@JessicaTegner
Copy link
Owner

@hey24sheep I wonder if GitHub Actions has something that can help us here.
In any case thank you, I'll wait for a little, to see if anyone can confirm.

And if you find anything else you want to contribute, feel free to open a separate issue or pr (for documentation, other fixes and the like)

@JessicaTegner JessicaTegner linked an issue Oct 11, 2022 that may be closed by this pull request
@JessicaTegner JessicaTegner merged commit 1a9e3e7 into JessicaTegner:master Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Platform architecture of ARM Linux system can be aarch64
2 participants