Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: delete block UI #327

Closed
wants to merge 55 commits into from
Closed

Conversation

GeronimoJohn
Copy link
Contributor

@GeronimoJohn GeronimoJohn commented Mar 4, 2022

Description

Created the UI for deleting a block. This was done by utilizing the API created for deleting blocks

How should this PR be QA Tested

  • Within the JourneyEdit page. Select a block within a card that you want to delete. Clicking on the delete icon should remove the block from the card
  • Within the JourneyEdit page. Select a block within a card that you want to delete. Click on the dot menu and then click on the delete block item. Clicking on it should remove the block from the card.
  • If the selected block is on the top of the list of blocks within the card. Upon deletion, the block below should automatically be selected.
  • If the selected block is in the middle of the list of blocks within the card. Upon deletion, the block below should automatically be selected.
  • If the selected block is last in the list of blocks within the card. Upon deletion, the block above should automatically be selected.

Checklist

  • I have performed a self-review of my own code

@GeronimoJohn GeronimoJohn added effort: 3 priority: soon type: feat Brand new functionality, features, pages, workflows, endpoints, etc. labels Mar 4, 2022
@GeronimoJohn GeronimoJohn added this to the 2022 - 02 Cycle milestone Mar 4, 2022
@GeronimoJohn GeronimoJohn self-assigned this Mar 4, 2022
@vercel
Copy link

vercel bot commented Mar 4, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

journeys – ./

🔍 Inspect: https://vercel.com/jesusfilm/journeys/HTdmuXUnxTKyni9MkUngGozh238q
✅ Preview: https://journeys-git-22-02-jg-feature-delete-block-ui-jesusfilm.vercel.app

journeys-admin – ./

🔍 Inspect: https://vercel.com/jesusfilm/journeys-admin/GhoekznuXdenhZE87uQWkFoKtepp
✅ Preview: https://journeys-admin-git-22-02-jg-feature-delete-block-ui-jesusfilm.vercel.app

@csiyang csiyang self-assigned this Mar 7, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2022

Fails
🚫 Your branch does not match the naming convention.
Warnings
⚠️ ❗ Big PR (1327 changes)

(change count - 1327): Pull Request size seems relatively large. If Pull Request contains multiple changes, split each into separate PR will helps faster, easier review.

(branch name - 22-02-JG-feature-delete-block-ui): see the Branch naming conventions here https://github.com/JesusFilm/core/wiki/Repository-Best-Practice#naming-your-branch

Generated by 🚫 dangerJS against 058f7e7

@csiyang csiyang requested a review from storyworks March 8, 2022 00:45
@csiyang csiyang requested a review from storyworks March 16, 2022 01:32
@csiyang csiyang marked this pull request as ready for review March 16, 2022 01:34
@csiyang csiyang changed the title feature: delete block UI feat: delete block UI Mar 16, 2022
@csiyang csiyang mentioned this pull request Mar 17, 2022
6 tasks
@csiyang
Copy link
Contributor

csiyang commented Mar 17, 2022

Re-raised here with updated branch naming

@csiyang csiyang closed this Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: 5 priority: soon type: feat Brand new functionality, features, pages, workflows, endpoints, etc.
Projects
None yet
4 participants