Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: EXPOSED-42 Can't create BLOB column with default value #1740

Merged
merged 4 commits into from May 23, 2023

Conversation

joc-a
Copy link
Collaborator

@joc-a joc-a commented May 11, 2023

This change makes it possible to set a default value to a BLOB column (BlobColumnType) by converting the byte array in ExposedBlob to a hex-encoded string and using that in the DDL when creating a table. Previously, this was an operation that failed.

@joc-a joc-a force-pushed the joc/blob-with-default branch 3 times, most recently from d9dc20b to 5ce96b4 Compare May 12, 2023 16:16
@joc-a joc-a linked an issue May 15, 2023 that may be closed by this pull request
@joc-a joc-a force-pushed the joc/blob-with-default branch 2 times, most recently from b8328e6 to 11c2c6d Compare May 15, 2023 14:23
joc-a added 2 commits May 15, 2023 16:24
In `nonNullValueToString` for `BlobColumnType`, the `ExposedBlob` is now converted into its hexadecimal representation as a `String`
@joc-a joc-a marked this pull request as ready for review May 15, 2023 15:25
@joc-a joc-a requested review from Tapac, e5l and bog-walk May 15, 2023 15:26
Copy link

@rsinukov rsinukov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but a minor comment

Copy link
Member

@e5l e5l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@joc-a joc-a merged commit f030818 into master May 23, 2023
3 checks passed
@joc-a joc-a deleted the joc/blob-with-default branch May 23, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't create BLOB column with default value
4 participants