feat: Add findByIdAndUpdate functions to DAO API #1773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reidbuzby
force-pushed
the
reidbuzby/dao-update-api
branch
from
7755e6c
to
af3f478
Compare
e5l
force-pushed
the
reidbuzby/dao-update-api
branch
from
af3f478
to
223e438
Compare
bog-walk
approved these changes
Jan 10, 2024
exposed-dao/src/main/kotlin/org/jetbrains/exposed/dao/EntityClass.kt
Outdated
Show resolved
Hide resolved
bog-walk
reviewed
Jan 10, 2024
|
@e5l Could the title of the PR also be changed? Because it currently sounds like update wasn't supported by DAO at all before. Maybe something like 'feat: Add findByIdAndUpdate functions to dao API'? |
e5l
changed the title
e5l
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there are no functions in the DAO api that directly allow updates. This change adds functions that allow direct updates in the EntityClass API. Usage guidelines are explained in the documentation updates.