Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add time extension function for temporal expressions in Kotlin and Java #2121

Merged

Conversation

joc-a
Copy link
Collaborator

@joc-a joc-a commented Jun 12, 2024

  • Added time extension functions for temporal expressions in Kotlin and Java.
  • Modified Time function to make it work for all database dialects.
  • Modified JodaTimeMiscTableTest and JodaTimeDefaultsTest to extend DatabaseTestsBase instead of JodaTimeBaseTest to match the way it is in the Kotlin and Java tests.
  • H2 V1 is excluded from the tests because of a bug in the driver that messes up the fractional seconds.

I'm planning to add more tests to cover more types in later pull requests.

@joc-a joc-a marked this pull request as ready for review June 12, 2024 14:04
private fun dateTimeWithFractionFormat(fraction: Int): DateTimeFormatter {
val baseFormat = "YYYY-MM-dd HH:mm:ss"
private fun dateTimeWithFractionFormat(date: String, fraction: Int): DateTimeFormatter {
val containsDatePart = date.contains("T") || date.contains(" ")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that it's duplicated in other datetime packages, and I believe that it works, but is it possible that containsDatePart is false here?

I wanted to write that if we use method inside DateColumnType class, and this method takes date: String argument, it must have date part, but now I see.

I don't expect that it's the problem of this PR, but it might be a problem in the long term. We have a DateColumnType class that is expected to be used with exact values from the database (actually also different values from different dialects, but it's another problem), but after that we query something like SUBSTRING(CONVERT(NVARCHAR, TestTable."timestamptz-column", 121), 12, 15) and expect that the column type should parse it also. And the problem is that we actually cannot say which values we expect from the database, we can rely only on what's covered by tests.

But I don't know is it easy to change with the current approach. Particularly for the time function, if the final goal is to return user the date from the whole timestamp, we can query the whole timestamp and extract time on the exposed side (instead of querying time only).

Anyway, it's just some thoughts about the potential problems with maintaining our datetime classes.

@joc-a joc-a force-pushed the joc/add-time-extension-function-for-temporal-expressions branch from 65335c2 to 6ca6888 Compare June 26, 2024 10:56
@joc-a joc-a changed the title feat: Add time extension function for temporal expressions feat: Add time extension function for temporal expressions in Kotlin and Java Jun 26, 2024
Copy link
Member

@bog-walk bog-walk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left small comments in the test files.

…and Java

H2 V1 is excluded because of a bug in the driver that messes up the fractional seconds
@joc-a joc-a force-pushed the joc/add-time-extension-function-for-temporal-expressions branch from 6ca6888 to 15cff13 Compare June 27, 2024 10:20
@joc-a joc-a merged commit 3fafec1 into main Jun 27, 2024
5 checks passed
@joc-a joc-a deleted the joc/add-time-extension-function-for-temporal-expressions branch June 27, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants