Oracle dialect #62
Merged
Oracle dialect #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any chance of merging this? |
|
@pjagielski , will try to review your changes asap, sorry for delay with that. |
|
@pjagielski , @adamdziedzic , Please checkout oracle-dialect branch and test it. If it works fine I will merge it back to master and make a release. |
|
OK, I'll try to test the new branch. However, we're not longer using Oracle on production, so I cannot give 100% guarantee that everything works ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Here's (almost complete) working Oracle dialect implementation.
There are some limitations that I've documented in separate ORACLE.md page (with test running instructions).
The biggest change is in
BatchInsertStatementsince Oracle doesn't support multiple rows in insert statement. So I split the arguments into multiple context andaddBatcheven if just single row is inserted.In our project we extensively use SQL DSL so it's pretty well tested in existing application. We don't use DAO feature so it's only covered by unit tests.
Looking forward for a review ;)