Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misaligned Height #218

Closed
rysktky opened this issue Apr 22, 2020 · 11 comments
Closed

Misaligned Height #218

rysktky opened this issue Apr 22, 2020 · 11 comments
Labels
hinting bug

Comments

@rysktky
Copy link

rysktky commented Apr 22, 2020 •
edited

Sometimes, the height of some Large letters and numbers are misaligned with some size.

  • This does NOT seem to happen with NL version.
  • This is NOT always reproducible. Even with the same settings, the problem only appears sometimes
  • Noticed this when I was changing font seizes, including zoom in and out, changing from the application menu.
  • Seems that NOT all editors/terminals are affected. (Seen on MS notepad and mintty for cygwin. Notepad++ or VSC seem to work OK)

image
Above shows some alphabets and 3 are lower.

image
with different size, now some large letters are taller.

image
This has gone very bad.

*Work around
Set it to another font and set it back to JetBrainsMono may(or may not) fix the alignment.

Could this be a hinting bug of JetBrainsMono or
a compatibility issue for some editors/terminals? (but not seen this with other fonts than JetBrainsMono)
@philippnurullin
Copy link
Member

Hi @rysktky . We had similar report #40
What version of the font you using?

@rysktky
Copy link
Author

rysktky commented Apr 23, 2020

@philippnurullin
Thank you for quick response!
I am using 1.0.5

@rysktky
Copy link
Author

rysktky commented Apr 24, 2020

I saw the same symptom with with NL version today when I was using it with MobaXtrem.

@philippnurullin
Copy link
Member

@rysktky Ok, then. We will need the info so we can reproduce the problems.

  1. Name end version of editors. It will be nice to have a screenshot for each case. Or you can just add the editor info to the screens you already took.
  2. OS with basic version.

@philippnurullin philippnurullin mentioned this issue Apr 24, 2020
Closed
@rysktky
Copy link
Author

rysktky commented Apr 25, 2020

@philippnurullin , Here are some new pictures.

All taken with the same PC, Windows10 Enterprise 1803.
Previous screenshots were taken with the same PC with mintty 3.1.4 with Cygwin (latest version)

I cannot really reproduce this constantly, especially the one with lower 'R' which is the first screenshot of this thread.

Still don' t know what makes these differences.

image

@rysktky
Copy link
Author

rysktky commented Apr 25, 2020

I just found that small letters are slightly misaligned sometimes as well.
(noticed this when typed 'vacuum')

image

Screenshots were taken with the same windows PC.

@mfocko
Copy link

mfocko commented Apr 25, 2020

Not sure if it's related, but I've noticed misaligned [] for Fira Code in Windows Terminal and only in Windows Terminal...

@rysktky
Copy link
Author

rysktky commented May 1, 2020

I agree with @mfocko . I haven't seen this with my Gnome desktop on my Fedora.

By the way, I just found Wireshark goes really messy almost always with the same Windows PC.
Hope this helps you, @philippnurullin .

Version 3.2.3 (v3.2.3-0-gf39b50865a13) ( Latest wire shark. Main window draws the same,,,)
image

This was referenced May 7, 2020
Closed
Closed
@archilkarchava
Copy link

archilkarchava commented May 14, 2020 •
edited

I downgraded to v1.0.4 and the problem is gone now in windows terminal.

philippnurullin added a commit that referenced this issue Jul 10, 2020
@philippnurullin
Updated to v2.000
598943b 
— Added 3 lighter weights with matching italics #1
SemiLight — Special for the dark background. It’s a slightly more thin version of Regular.
Light — Will perform best on HiDpi in more big sizes.
ExtraLight — If you want to go even thinner. Recommended for presentation mode.
— Added Variable format for more precise weight tuning.
— Project migrated from FontLab to Glyphs. Source in UFO provided.
— *ML comment ligatures are vertically misaligned #77
— Ligatures in a glob pattern look inconsistent #88
— Zero - hinting the dot #104
— Big space above text in OneNote #210
— Corrected hinting #218 #235 #239 #252
— Monospaced detection errors  #227 #230
— Wrong interpretation in "<||> |>" #234
— Reworked % ‰ #236
— Missing some Powerline symbols #240
— Disable `>-` ligature when followed by `<` (`>-<`) #251
— Add the Latin Capital Letter Sharp S (U+1E9E) #262
— Added superior & inferior numbers ⁰¹²³⁴⁵⁶⁷⁸⁹₀₁₂₃₄₅₆₇₈₉
— Fine tuning of capital, ascender & descender metrics
— Raised the bar in `f` to work better in context of the line
— More spacing tuning in arrow ligatures
— Corrections in  -<  -<<  <— <!—
— More pronounced bar in Ħ Ŧ ћ ħ đ ŧ
— Correct u+02C9 placement
— Corrected placement of Ogonek in Uogonek
— Corrections in Vietnamese diacritics
@rysktky
Copy link
Author

rysktky commented Jul 13, 2020

Thanks for the awesome font and work!!

@philippnurullin
Copy link
Member

@rysktky You are welcome. ))

@fredizzimo fredizzimo mentioned this issue Jan 25, 2022
Closed
@fredizzimo fredizzimo mentioned this issue Sep 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hinting bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mfocko @archilkarchava @rysktky @philippnurullin