Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ligatures request: /\ and \/ #222

Closed
srghma opened this issue Apr 25, 2020 · 5 comments
Closed

Ligatures request: /\ and \/ #222

srghma opened this issue Apr 25, 2020 · 5 comments
Labels
enhancement New feature or request

Comments

@srghma
Copy link

srghma commented Apr 25, 2020

the interesting question is how they will look inside the regex

/\s/

I think it should ligate, but height should be consistent

@alexeyten
Copy link
Contributor

They was removed exactly because they looked wrong in regexps. #78 (comment)

@srghma
Copy link
Author

srghma commented Apr 25, 2020

also it should work even when surrounded by spaces

e.g. there is an issue in https://github.com/tonsky/FiraCode/issues/1013

@srghma
Copy link
Author

srghma commented Apr 25, 2020

They was removed exactly because they looked wrong in regexps. #78 (comment)

hi, well, I understand, but maybe it can be ligated only when surrounded by whitespace OR start/end of line

e.g. in haskell \/ is either function. Example - doOnLeft \/ doOnRight $ xxx

@philippnurullin philippnurullin added the enhancement New feature or request label Jul 9, 2020
@philippnurullin
Copy link
Member

@srghma Hi, i will add this in one of the next updates.

@philippnurullin
Copy link
Member

tonsky/FiraCode#1013

philippnurullin added a commit that referenced this issue Oct 4, 2022
- Added \/ /\ ligatures #222
- Added ➔ ➝ ➞ #545
- Added names for OpenType features
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants