Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request for supporting multiline bracket characters #290

Closed
mahozad opened this issue Aug 19, 2020 · 5 comments
Closed

Request for supporting multiline bracket characters #290

mahozad opened this issue Aug 19, 2020 · 5 comments
Labels
unicode request Request for adding more symbols
Milestone

Comments

@mahozad
Copy link

mahozad commented Aug 19, 2020

The glyphs for multi-line bracket characters are not in full height:
Screenshot (890)

The official list of supported symbols dose not contain these characters in the first place.
Is it possible to add support for them?

I found some multiline brackets in this Wikipedia page.

The above image shows the default JetBrainsMono font in IntelliJ IDEA 2020.2.


As a side note I should say that the box-drawing characters have a tiny gap between them as well.

@philippnurullin philippnurullin added the unicode request Request for adding more symbols label Aug 19, 2020
@philippnurullin
Copy link
Member

philippnurullin commented Aug 31, 2020

Hi @mahozad Please paste the code with brackets that on you screen. It will be easy for me to find the exact symbols you want to be added.

As for the space between the boxdrawing symbols. Make sure that your line height in setting is set to 1.0. You can find this option in PreferencesEditorLine spacing.

@mahozad
Copy link
Author

mahozad commented Sep 1, 2020

Sure. This is the example code:

 ⎛                ⎞
 ⎜ very important ⎟
 ⎝                ⎠

I typed these chars in the editor with line spacing set to 1.0:

    ┌──┬──┐
    ├     ┤
    └──┴──┘

JetBrains Mono:
jetbrains-mono

Fira Code:
fira-code

It seems to me that with small font sizes there is even horizontal gap between the symbols.

I should say it again that this is the default font in IntelliJ IDEA 2020.2 (so I think it is not version 2.000 of font)

@philippnurullin philippnurullin added this to the v2.300 milestone Dec 21, 2020
philippnurullin added a commit that referenced this issue Jan 22, 2021
- Added exclusion in -> ligature to look reasonable in negative arguments for C++ <1-> #107
- /** brought back #202
- */ /* aligned to match *  #215
- Added multiline bracket characters ⎛ ⎞ ⎝ ⎠ ⎜ #290
- Fixed Powerline arrows height #395
@philippnurullin
Copy link
Member

Please grab the files from here https://github.com/JetBrains/JetBrainsMono/tree/master/fonts to confirm.

@mahozad
Copy link
Author

mahozad commented Jan 24, 2021

@philippnurullin With font size 13 and line spacing 1.0, there seems a little bit vertical overlap between them. But anyway, thank you.

@philippnurullin
Copy link
Member

@mahozad Yes, the overlap can be present. It can occur when some rounding is applied to calculation of line height in IDE. The height of multiline brackets can be reduced but is will create gaps in some cases, so that's a compromise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
unicode request Request for adding more symbols
Projects
None yet
Development

No branches or pull requests

2 participants