Cache results of font-config pattern search for reuse #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@avu I have signed the CLA. You can change NUM_CACHED_VALUES to 0 to disable the caching mechanism to compare the performance. I choose the value of 8 empirically based on what smoothed out the UI sufficiently without frequent eviction. I didn't try tuning the Pattern to FcFontMatch. Maybe there is an improved pattern that quickly retrieves the required values. |
|
@osialr thanks for signing. I've tested the patch - it greatly improves the performance. Nice work! Looking deeply into the implementation ... |
avu
approved these changes
Apr 28, 2022
|
@osialr the changes look good, I've run commit testing and pushed them into JBR11 master |
|
Great. I'm glad to help. |
|
@osialr thank you very much for your help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a potential fix for #84. libfontmanager invokes the fontconfig matcher very often, especially on editor font-size. The implementation caches the results of the calls.
On my system, each call to match takes between 10-20 ms, with a few >100ms. Kubuntu + libreoffice exacerbates the problem, because it installs a lot of fonts and rules. But even on a minimal install of ubuntu, this should help because each call takes 1-10ms.
See IDEA-287246 for more debug diagnostics.