JBR-6771 BoxLayout throws mysterious NPEs due to previous exceptions #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vprovodin
force-pushed
the
main
branch
2 times, most recently
from
d32cd9e
to
b304693
Compare
Initialize currentDisplayID on AWTWindow creation
…n default NIO file system
…he UnixFileSystem, which might not be the case
…s full screen This includes displaySync changes as well as fixes for JBR-5157 and JBR-5321.
Removed extra command queue
Use separate glyph cache for each MTLContext instance. Refactored MTLGlyphCache
…nnouncer_nativeAnnounce Stop using the JNIEnv instance bound to EDT in the AppKit thread. (cherry picked from commit 0f49341)
… queue Added command queue and provided synchronization between the command queues
…uffer and a specific shader (vert_txt_col) fix crash in J2DDemo with advanced paints + artefacts with texture background
…ronization in metal (MBP 16'' x64) Removed NSLock and moved all operations to the AppKit thread
vprovodin
force-pushed
the
main
branch
9 times, most recently
from
68b2f88
to
1eb1e72
Compare
vprovodin
force-pushed
the
main
branch
9 times, most recently
from
9c64d1c
to
5017512
Compare
YaaZ
force-pushed
the
main
branch
2 times, most recently
from
c68b05d
to
c9ce3ca
Compare
vprovodin
force-pushed
the
main
branch
3 times, most recently
from
9968442
to
8848310
Compare
vprovodin
force-pushed
the
main
branch
4 times, most recently
from
8e5386f
to
b48a181
Compare
|
Merged into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't really a bug, more like an inconvenience that masks real bugs.
The
checkRequestsmethod only does layout initializationif it isn't initialized already. However, when an exception
is thrown during the initialization, the layout may end up
in a half-initialized state.
Fix this by using the field that is initialized the last to check
if the layout is initialized. If that field is null, it may mean
that the layout isn't initialized or that the last attempt
failed midway. Then we try again. This attempt can,
of course, break for the same reason as the previous one,
but in that case we'll at least get a stack trace pointing
to a real cause of the error and not some mysterious NPE
that seems to be impossible from the logic.