JBR-7256 Vulkan: Implement FILL_PARALLELOGRAM primitive for flat color rendering #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YaaZ
approved these changes
Jun 13, 2024
There was a problem hiding this comment.
Overall LGTM, but I'm thinking, maybe we could have a unified pipeline at least for colored primitive case, so that we could batch multiple primitives with different colors. Also as far as I can see, vertex buffers are being created and never destroyed, but this will be solved by buffer pools and proper resource management.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented FILL_PARALLELOGRAM RQ primitive
Changed color shader to use push constant for color